where does this surface an issue for you? do you depend on reth-rpc-types directly or some other crate that depends on it?

Yes, we do depend on this crate for ZK rollups on Sovereign SDK.

Also, original code has "jsonrpsee-types" in default features, so I thought that intent is to not have those types in non-default, which this PR does.

for instance ring v17.

do you know which one pulls that in?

for instance ring v17.

do you know which one pulls that in?

It is via alloy-rpc-types-beacon -> alloy-rpc-types-engine and then jsonwebtoken
Yes, here is in our tree:

│   │   ├── reth-rpc-types v1.0.4 (https://github.com/paradigmxyz/reth?rev=d29c5a88075f8f5e99e844baa34ff60e92e794cb#d29c5a88)
│   │   │   ├── alloy-primitives v0.7.7 (*)
│   │   │   ├── alloy-rpc-types v0.2.1
│   │   │   │   └── ..
│   │   │   ├── alloy-rpc-types-admin v0.2.1
│   │   │   │   └── ..
│   │   │   ├── alloy-rpc-types-anvil v0.2.1
│   │   │   │   └── ..
│   │   │   ├── alloy-rpc-types-beacon v0.2.1
│   │   │   │   ├── alloy-eips v0.2.1 (*)
│   │   │   │   ├── alloy-primitives v0.7.7 (*)
│   │   │   │   ├── alloy-rpc-types-engine v0.2.1
│   │   │   │   │   ├── ...
│   │   │   │   │   ├── jsonwebtoken v9.3.0
│   │   │   │   │   │   ├── base64 v0.21.7
│   │   │   │   │   │   ├── pem v3.0.4
│   │   │   │   │   │   │   └── base64 v0.22.1
│   │   │   │   │   │   ├── ring v0.17.8
...

gotcha, supportive, although this crate acts as a container crate that re-exports stuff, I assume you could also cherry pick only those alloy crates that you need

Thank you for suggestion, I will explore that.

But this PR will allows us to switch from our fork to original this upstream repo .

Maybe it stretches a little bit, but this crate on main branch is not compiles with default features off.

looks like the cargo hack job found the first issue :)